Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: google_apis/gcm/base/mcs_message_unittest.cc

Issue 171683002: [GCM] Fix gcm login to properly identify chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_util.h » ('j') | google_apis/gcm/base/mcs_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/base/mcs_message_unittest.cc
diff --git a/google_apis/gcm/base/mcs_message_unittest.cc b/google_apis/gcm/base/mcs_message_unittest.cc
index 07f1d7da24c9a4cb616dbaad919820e68449c6ff..0dbebc7cc45cf55183dce9261cfb6f40d82d99de 100644
--- a/google_apis/gcm/base/mcs_message_unittest.cc
+++ b/google_apis/gcm/base/mcs_message_unittest.cc
@@ -37,7 +37,7 @@ TEST_F(MCSMessageTest, Invalid) {
TEST_F(MCSMessageTest, InitInferTag) {
std::vector<int64> user_serial_numbers;
scoped_ptr<mcs_proto::LoginRequest> login_request(
- BuildLoginRequest(kAndroidId, kSecret, user_serial_numbers));
+ BuildLoginRequest(kAndroidId, kSecret, "", user_serial_numbers));
scoped_ptr<google::protobuf::MessageLite> login_copy(
new mcs_proto::LoginRequest(*login_request));
MCSMessage message(*login_copy);
@@ -56,7 +56,7 @@ TEST_F(MCSMessageTest, InitInferTag) {
TEST_F(MCSMessageTest, InitWithTag) {
std::vector<int64> user_serial_numbers;
scoped_ptr<mcs_proto::LoginRequest> login_request(
- BuildLoginRequest(kAndroidId, kSecret, user_serial_numbers));
+ BuildLoginRequest(kAndroidId, kSecret, "", user_serial_numbers));
scoped_ptr<google::protobuf::MessageLite> login_copy(
new mcs_proto::LoginRequest(*login_request));
MCSMessage message(kLoginRequestTag, *login_copy);
@@ -75,7 +75,7 @@ TEST_F(MCSMessageTest, InitWithTag) {
TEST_F(MCSMessageTest, InitPassOwnership) {
std::vector<int64> user_serial_numbers;
scoped_ptr<mcs_proto::LoginRequest> login_request(
- BuildLoginRequest(kAndroidId, kSecret, user_serial_numbers));
+ BuildLoginRequest(kAndroidId, kSecret, "", user_serial_numbers));
scoped_ptr<google::protobuf::MessageLite> login_copy(
new mcs_proto::LoginRequest(*login_request));
MCSMessage message(kLoginRequestTag,
« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_util.h » ('j') | google_apis/gcm/base/mcs_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698