Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: google_apis/gcm/engine/mcs_client_unittest.cc

Issue 171683002: [GCM] Fix gcm login to properly identify chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/engine/mcs_client.cc ('k') | google_apis/gcm/gcm_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/mcs_client_unittest.cc
diff --git a/google_apis/gcm/engine/mcs_client_unittest.cc b/google_apis/gcm/engine/mcs_client_unittest.cc
index 2b952543eaf5d6958298e9f4a185dd63b609ac93..da88f26e5207c316468561c09611c06f31f027a9 100644
--- a/google_apis/gcm/engine/mcs_client_unittest.cc
+++ b/google_apis/gcm/engine/mcs_client_unittest.cc
@@ -67,7 +67,7 @@ class TestMCSClient : public MCSClient {
TestMCSClient(base::Clock* clock,
ConnectionFactory* connection_factory,
GCMStore* gcm_store)
- : MCSClient(clock, connection_factory, gcm_store),
+ : MCSClient("", clock, connection_factory, gcm_store),
next_id_(0) {
}
@@ -180,7 +180,7 @@ void MCSClientTest::InitializeClient() {
void MCSClientTest::LoginClient(
const std::vector<std::string>& acknowledged_ids) {
scoped_ptr<mcs_proto::LoginRequest> login_request =
- BuildLoginRequest(kAndroidId, kSecurityToken);
+ BuildLoginRequest(kAndroidId, kSecurityToken, "");
for (size_t i = 0; i < acknowledged_ids.size(); ++i)
login_request->add_received_persistent_id(acknowledged_ids[i]);
GetFakeHandler()->ExpectOutgoingMessage(
@@ -346,7 +346,7 @@ TEST_F(MCSClientTest, SendMessageRMQWhileDisconnected) {
GetFakeHandler()->ExpectOutgoingMessage(
MCSMessage(
kLoginRequestTag,
- BuildLoginRequest(kAndroidId, kSecurityToken).
+ BuildLoginRequest(kAndroidId, kSecurityToken, "").
PassAs<const google::protobuf::MessageLite>()));
// The second (re)send.
MCSMessage message2(BuildDataMessage(
« no previous file with comments | « google_apis/gcm/engine/mcs_client.cc ('k') | google_apis/gcm/gcm_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698