Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: google_apis/gcm/engine/mcs_client.h

Issue 171683002: [GCM] Fix gcm login to properly identify chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/engine/connection_handler_impl_unittest.cc ('k') | google_apis/gcm/engine/mcs_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/mcs_client.h
diff --git a/google_apis/gcm/engine/mcs_client.h b/google_apis/gcm/engine/mcs_client.h
index 1834b9561c56d513030de81d3915eb7a86b8ab79..a81643bf9b9e10ab848fd6f6887e828fcf225365 100644
--- a/google_apis/gcm/engine/mcs_client.h
+++ b/google_apis/gcm/engine/mcs_client.h
@@ -84,7 +84,8 @@ class GCM_EXPORT MCSClient {
const std::string& message_id,
MessageSendStatus status)> OnMessageSentCallback;
- MCSClient(base::Clock* clock,
+ MCSClient(const std::string& version_string,
+ base::Clock* clock,
ConnectionFactory* connection_factory,
GCMStore* gcm_store);
virtual ~MCSClient();
@@ -197,6 +198,9 @@ class GCM_EXPORT MCSClient {
// any associated state).
MCSPacketInternal PopMessageForSend();
+ // Local version string. Sent on login.
+ const std::string version_string_;
+
// Clock for enforcing TTL. Passed in for testing.
base::Clock* const clock_;
« no previous file with comments | « google_apis/gcm/engine/connection_handler_impl_unittest.cc ('k') | google_apis/gcm/engine/mcs_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698