Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: google_apis/gcm/base/mcs_message_unittest.cc

Issue 171683002: [GCM] Fix gcm login to properly identify chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/base/mcs_message_unittest.cc
diff --git a/google_apis/gcm/base/mcs_message_unittest.cc b/google_apis/gcm/base/mcs_message_unittest.cc
index 4d4ef598ad2a684b66e9505879871e8c3887170e..55ab49d130f91561ba6abdfcd0a34ebb69f894eb 100644
--- a/google_apis/gcm/base/mcs_message_unittest.cc
+++ b/google_apis/gcm/base/mcs_message_unittest.cc
@@ -36,7 +36,7 @@ TEST_F(MCSMessageTest, Invalid) {
TEST_F(MCSMessageTest, InitInferTag) {
scoped_ptr<mcs_proto::LoginRequest> login_request(
- BuildLoginRequest(kAndroidId, kSecret));
+ BuildLoginRequest(kAndroidId, kSecret, ""));
scoped_ptr<google::protobuf::MessageLite> login_copy(
new mcs_proto::LoginRequest(*login_request));
MCSMessage message(*login_copy);
@@ -54,7 +54,7 @@ TEST_F(MCSMessageTest, InitInferTag) {
TEST_F(MCSMessageTest, InitWithTag) {
scoped_ptr<mcs_proto::LoginRequest> login_request(
- BuildLoginRequest(kAndroidId, kSecret));
+ BuildLoginRequest(kAndroidId, kSecret, ""));
scoped_ptr<google::protobuf::MessageLite> login_copy(
new mcs_proto::LoginRequest(*login_request));
MCSMessage message(kLoginRequestTag, *login_copy);
@@ -72,7 +72,7 @@ TEST_F(MCSMessageTest, InitWithTag) {
TEST_F(MCSMessageTest, InitPassOwnership) {
scoped_ptr<mcs_proto::LoginRequest> login_request(
- BuildLoginRequest(kAndroidId, kSecret));
+ BuildLoginRequest(kAndroidId, kSecret, ""));
scoped_ptr<google::protobuf::MessageLite> login_copy(
new mcs_proto::LoginRequest(*login_request));
MCSMessage message(kLoginRequestTag,
« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698