Use GpuPreferences to avoid directly accessing switches in gpu related code

gpu/command_buffer/service/feature_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
-#include "gpu/command_buffer/service/gpu_switches.h"
+#include "gpu/command_buffer/service/gpu_preferences.h"
 #include "gpu/command_buffer/service/texture_definition.h"
 #include "gpu/config/gpu_switches.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_fence.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_switches.h"
 #include "ui/gl/gl_version_info.h"
 
 #if !defined(OS_MACOSX)
 #include "ui/gl/gl_fence_egl.h"
@@ skipping 49 matching lines @@
     return string_set_;
   }
 
  private:
   std::set<std::string> string_set_;
 };
 
 // Process a string of wordaround type IDs (seperated by ',') and set up
 // the corresponding Workaround flags.
 void StringToWorkarounds(
-    const std::string& types, FeatureInfo::Workarounds* workarounds) {
+    const std::set<int>& workaround_set,
+    FeatureInfo::Workarounds* workarounds) {
   DCHECK(workarounds);
-  for (const base::StringPiece& piece :
-       base::SplitStringPiece(
-           types, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
-    int number = 0;
-    bool succeed = base::StringToInt(piece, &number);
-    DCHECK(succeed);
+  for (auto number : workaround_set) {
     switch (number) {
 #define GPU_OP(type, name)    \
   case gpu::type:             \
     workarounds->name = true; \
     break;
       GPU_DRIVER_BUG_WORKAROUNDS(GPU_OP)
 #undef GPU_OP
       default:
         NOTIMPLEMENTED();
     }
@@ skipping 95 matching lines @@
 }
 
 FeatureInfo::FeatureInfo(const base::CommandLine& command_line) {
   InitializeBasicState(&command_line);
 }
 
 void FeatureInfo::InitializeBasicState(const base::CommandLine* command_line) {
   if (!command_line)
     return;
 
-  if (command_line->HasSwitch(switches::kGpuDriverBugWorkarounds)) {
-    std::string types = command_line->GetSwitchValueASCII(
-        switches::kGpuDriverBugWorkarounds);
-    StringToWorkarounds(types, &workarounds_);
-  }
+  const GpuPreferences* gpu_preferences = GpuPreferences::GetInstance();
+
+  StringToWorkarounds(gpu_preferences->gpu_driver_bug_workarounds,
+                      &workarounds_);
   feature_flags_.enable_shader_name_hashing =
-      !command_line->HasSwitch(switches::kDisableShaderNameHashing);
+      !gpu_preferences->disable_shader_name_hashing;
 
   feature_flags_.is_swiftshader =
       (command_line->GetSwitchValueASCII(switches::kUseGL) == "swiftshader");
 
   feature_flags_.enable_subscribe_uniform =
-      command_line->HasSwitch(switches::kEnableSubscribeUniformExtension);
+      gpu_preferences->enable_subscribe_uniform_extension;
 
-  enable_unsafe_es3_apis_switch_ =
-      command_line->HasSwitch(switches::kEnableUnsafeES3APIs);
+  enable_unsafe_es3_apis_switch_ = gpu_preferences->enable_unsafe_es3_apis;
 
-  enable_gl_path_rendering_switch_ =
-      command_line->HasSwitch(switches::kEnableGLPathRendering);
+  enable_gl_path_rendering_switch_ = gpu_preferences->enable_gl_path_rendering;
 
   // The shader translator is needed to translate from WebGL-conformant GLES SL
   // to normal GLES SL, enforce WebGL conformance, translate from GLES SL 1.0 to
   // target context GLSL, implement emulation of OpenGL ES features on OpenGL,
   // etc.
   // The flag here is for testing only.
-  disable_shader_translator_ =
-      command_line->HasSwitch(switches::kDisableGLSLTranslator);
+  disable_shader_translator_ = gpu_preferences->disable_glsl_translator;
 
   unsafe_es3_apis_enabled_ = false;
 
   // Default context_type_ to a GLES2 Context.
   context_type_ = CONTEXT_TYPE_OPENGLES2;
 
   chromium_color_buffer_float_rgba_available_ = false;
   chromium_color_buffer_float_rgb_available_ = false;
   ext_color_buffer_float_available_ = false;
   oes_texture_float_linear_available_ = false;
@@ skipping 1192 matching lines @@
   if (pos == std::string::npos) {
     extensions_ += (extensions_.empty() ? "" : " ") + str;
   }
 }
 
 FeatureInfo::~FeatureInfo() {
 }
 
 }  // namespace gles2
 }  // namespace gpu