Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: android_webview/browser/deferred_gpu_command_service.h

Issue 1716813002: Use GpuPreferences to avoid directly accessing switches in gpu related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address the review issue Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/browser/deferred_gpu_command_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_DEFERRED_GPU_COMMAND_SERVICE_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_DEFERRED_GPU_COMMAND_SERVICE_H_
6 #define ANDROID_WEBVIEW_BROWSER_DEFERRED_GPU_COMMAND_SERVICE_H_ 6 #define ANDROID_WEBVIEW_BROWSER_DEFERRED_GPU_COMMAND_SERVICE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <queue> 10 #include <queue>
11 #include <utility> 11 #include <utility>
12 12
13 #include "base/lazy_instance.h" 13 #include "base/lazy_instance.h"
14 #include "base/macros.h" 14 #include "base/macros.h"
15 #include "base/memory/ref_counted.h" 15 #include "base/memory/ref_counted.h"
16 #include "base/memory/scoped_ptr.h" 16 #include "base/memory/scoped_ptr.h"
17 #include "base/threading/thread_local.h" 17 #include "base/threading/thread_local.h"
18 #include "base/time/time.h" 18 #include "base/time/time.h"
19 #include "gpu/command_buffer/service/gpu_preferences.h"
19 #include "gpu/command_buffer/service/in_process_command_buffer.h" 20 #include "gpu/command_buffer/service/in_process_command_buffer.h"
20 21
21 namespace gpu { 22 namespace gpu {
22 class SyncPointManager; 23 class SyncPointManager;
23 } 24 }
24 25
25 namespace android_webview { 26 namespace android_webview {
26 27
27 class ScopedAllowGL { 28 class ScopedAllowGL {
28 public: 29 public:
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 67
67 protected: 68 protected:
68 ~DeferredGpuCommandService() override; 69 ~DeferredGpuCommandService() override;
69 friend class base::RefCountedThreadSafe<DeferredGpuCommandService>; 70 friend class base::RefCountedThreadSafe<DeferredGpuCommandService>;
70 71
71 private: 72 private:
72 friend class ScopedAllowGL; 73 friend class ScopedAllowGL;
73 static void RequestProcessGL(bool for_idle); 74 static void RequestProcessGL(bool for_idle);
74 75
75 DeferredGpuCommandService(); 76 DeferredGpuCommandService();
77 gpu::GpuPreferences GetGpuPreferences();
piman 2016/02/25 22:58:29 static
Peng 2016/02/26 15:41:11 Done. I moved this function into the anonymous nam
76 size_t IdleQueueSize(); 78 size_t IdleQueueSize();
77 79
78 base::Lock tasks_lock_; 80 base::Lock tasks_lock_;
79 std::queue<base::Closure> tasks_; 81 std::queue<base::Closure> tasks_;
80 std::queue<std::pair<base::Time, base::Closure> > idle_tasks_; 82 std::queue<std::pair<base::Time, base::Closure> > idle_tasks_;
81 83
82 scoped_ptr<gpu::SyncPointManager> sync_point_manager_; 84 scoped_ptr<gpu::SyncPointManager> sync_point_manager_;
83 scoped_refptr<gpu::gles2::ShaderTranslatorCache> shader_translator_cache_; 85 scoped_refptr<gpu::gles2::ShaderTranslatorCache> shader_translator_cache_;
84 scoped_refptr<gpu::gles2::FramebufferCompletenessCache> 86 scoped_refptr<gpu::gles2::FramebufferCompletenessCache>
85 framebuffer_completeness_cache_; 87 framebuffer_completeness_cache_;
86 DISALLOW_COPY_AND_ASSIGN(DeferredGpuCommandService); 88 DISALLOW_COPY_AND_ASSIGN(DeferredGpuCommandService);
87 }; 89 };
88 90
89 } // namespace android_webview 91 } // namespace android_webview
90 92
91 #endif // ANDROID_WEBVIEW_BROWSER_DEFERRED_GPU_COMMAND_SERVICE_H_ 93 #endif // ANDROID_WEBVIEW_BROWSER_DEFERRED_GPU_COMMAND_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | android_webview/browser/deferred_gpu_command_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698