Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1716793003: Enforce Capability Filter provided in manifest (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@9deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This enforces the capability filter specified in an application manifest. Note that this is mostly set to permissive right now because the capability filters as currently specified are a PITA to use. I'm going to be working with some of the security folk to devise a way to simplify this. Committed: https://crrev.com/7569dae2853e09aa469900f354c9121ef0a09b92 Cr-Commit-Position: refs/heads/master@{#376940}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -34 lines) Patch
M ash/mus/manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
A components/filesystem/apptest_manifest.json View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M components/filesystem/manifest.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/manifest.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
A components/leveldb/apptest_manifest.json View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M components/leveldb/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/mus/manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -0 lines 0 comments Download
A components/mus/ws/apptest_manifest.json View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M components/resource_provider/BUILD.gn View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
A components/resource_provider/apptest_manifest.json View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M components/resource_provider/manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mash/browser_driver/manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mash/example/views_examples/BUILD.gn View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
A mash/example/views_examples/manifest.json View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 2 3 4 3 chunks +8 lines, -0 lines 0 comments Download
A mash/example/window_type_launcher/manifest.json View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M mash/quick_launch/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mash/shell/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/BUILD.gn View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
A mash/wm/apptest_manifest.json View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M mash/wm/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 4 5 6 7 8 9 4 chunks +13 lines, -0 lines 0 comments Download
A media/mojo/services/apptest_manifest.json View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
A media/mojo/services/pipeline_apptest_manifest.json View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/mojo_application_manifest.gni View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/package_manager/manifest.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/package_manager/package_manager.cc View 1 2 3 4 5 2 chunks +9 lines, -5 lines 0 comments Download
M mojo/services/tracing/manifest.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager.cc View 1 2 3 4 5 3 chunks +13 lines, -9 lines 0 comments Download
M mojo/shell/tests/application_manager_apptest_driver_manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/application_manager_apptest_manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/package_test_app_a_manifest.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/package_test_app_b_manifest.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/package_test_package_manifest.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 35 (20 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-22 20:22:23 UTC) #3
sky
LGTM
4 years, 10 months ago (2016-02-22 21:35:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716793003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716793003/100001
4 years, 10 months ago (2016-02-22 21:47:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/184914)
4 years, 10 months ago (2016-02-22 23:38:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716793003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716793003/120001
4 years, 10 months ago (2016-02-23 00:28:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/185012)
4 years, 10 months ago (2016-02-23 02:18:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716793003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716793003/140001
4 years, 10 months ago (2016-02-23 02:38:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/119688) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-23 02:43:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716793003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716793003/160001
4 years, 10 months ago (2016-02-23 03:51:08 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/119713) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-23 03:55:29 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716793003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716793003/180001
4 years, 10 months ago (2016-02-23 04:52:13 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/185163)
4 years, 10 months ago (2016-02-23 06:04:17 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716793003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716793003/180001
4 years, 10 months ago (2016-02-23 06:57:37 UTC) #31
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 10 months ago (2016-02-23 07:28:58 UTC) #33
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 07:30:17 UTC) #35
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/7569dae2853e09aa469900f354c9121ef0a09b92
Cr-Commit-Position: refs/heads/master@{#376940}

Powered by Google App Engine
This is Rietveld 408576698