Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1716793002: [Interpreter] Support relevant FLAG_s in generate-bytecode-expectations. (Closed)

Created:
4 years, 10 months ago by Stefano Sanfilippo
Modified:
4 years, 10 months ago
Reviewers:
oth, rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Support relevant FLAG_s in generate-bytecode-expectations. FLAG_legacy_const and FLAG_harmony_do_expressions can now be toggled both through the command line and through the option header. BUG=v8:4280 LOG=N Committed: https://crrev.com/4f0be51987f34ec18440cf5259b0b58a5fc4c04a Cr-Commit-Position: refs/heads/master@{#34160}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Flip => Enable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M test/cctest/interpreter/generate-bytecode-expectations.cc View 1 8 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Stefano Sanfilippo
4 years, 10 months ago (2016-02-19 12:43:09 UTC) #2
rmcilroy
LGTM. https://codereview.chromium.org/1716793002/diff/1/test/cctest/interpreter/generate-bytecode-expectations.cc File test/cctest/interpreter/generate-bytecode-expectations.cc (right): https://codereview.chromium.org/1716793002/diff/1/test/cctest/interpreter/generate-bytecode-expectations.cc#newcode406 test/cctest/interpreter/generate-bytecode-expectations.cc:406: " --legacy-const Flip legacy_const flag.\n" /s/Flip/Enable the/ https://codereview.chromium.org/1716793002/diff/1/test/cctest/interpreter/generate-bytecode-expectations.cc#newcode407 ...
4 years, 10 months ago (2016-02-19 14:22:18 UTC) #3
Stefano Sanfilippo
https://codereview.chromium.org/1716793002/diff/1/test/cctest/interpreter/generate-bytecode-expectations.cc File test/cctest/interpreter/generate-bytecode-expectations.cc (right): https://codereview.chromium.org/1716793002/diff/1/test/cctest/interpreter/generate-bytecode-expectations.cc#newcode406 test/cctest/interpreter/generate-bytecode-expectations.cc:406: " --legacy-const Flip legacy_const flag.\n" On 2016/02/19 14:22:18, rmcilroy ...
4 years, 10 months ago (2016-02-19 14:35:01 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716793002/20001
4 years, 10 months ago (2016-02-19 14:37:42 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 14:57:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716793002/20001
4 years, 10 months ago (2016-02-19 15:50:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 15:52:54 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 15:53:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f0be51987f34ec18440cf5259b0b58a5fc4c04a
Cr-Commit-Position: refs/heads/master@{#34160}

Powered by Google App Engine
This is Rietveld 408576698