|
|
Created:
4 years, 10 months ago by alex clarke (OOO till 29th) Modified:
4 years, 10 months ago Reviewers:
haraken CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, kinuko+watch, Eric Willigers Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor ScrollAnimatorMac to use CancellableTaskFactory
Refactor ScrollAnimatorMac to use CancellableTaskFactory because the
unittests trigger ScrollAnimatorMac::sendContentAreaScrolledSoon which
causes an assert (TestingPlatformMockWebTaskRunner::
monotonicallyIncreasingVirtualTimeSeconds is called) to fire after
https://codereview.chromium.org/1646583002 lands.
Changing over to CancellableTaskFactory means we can bypass the
assert.
BUG=546953
Committed: https://crrev.com/5a94b8b2e63a4307b7be5eccc698b37c97fe9edc
Cr-Commit-Position: refs/heads/master@{#376453}
Patch Set 1 #Patch Set 2 : Fix compile #Patch Set 3 : Fix compile #Patch Set 4 : Need to implement TestingPlatformMockWebTaskRunner::clone #
Messages
Total messages: 41 (23 generated)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/1
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/20001
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/60001
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #2 (id:60001) has been deleted
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/80001
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/100001
Patchset #2 (id:100001) has been deleted
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/120001
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/140001
alexclarke@chromium.org changed reviewers: + haraken@chromium.org
Please take a look.
LGTM
The CQ bit was unchecked by alexclarke@chromium.org
The CQ bit was checked by alexclarke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/140001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by alexclarke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/1716713003/#ps160001 (title: "Need to implement TestingPlatformMockWebTaskRunner::clone")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/160001
Message was sent while issue was closed.
Committed patchset #4 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Refactor ScrollAnimatorMac to use CancellableTaskFactory Refactor ScrollAnimatorMac to use CancellableTaskFactory because the unittests trigger ScrollAnimatorMac::sendContentAreaScrolledSoon which causes an assert (TestingPlatformMockWebTaskRunner:: monotonicallyIncreasingVirtualTimeSeconds is called) to fire after https://codereview.chromium.org/1646583002 lands. Changing over to CancellableTaskFactory means we can bypass the assert. BUG=546953 ========== to ========== Refactor ScrollAnimatorMac to use CancellableTaskFactory Refactor ScrollAnimatorMac to use CancellableTaskFactory because the unittests trigger ScrollAnimatorMac::sendContentAreaScrolledSoon which causes an assert (TestingPlatformMockWebTaskRunner:: monotonicallyIncreasingVirtualTimeSeconds is called) to fire after https://codereview.chromium.org/1646583002 lands. Changing over to CancellableTaskFactory means we can bypass the assert. BUG=546953 Committed: https://crrev.com/5a94b8b2e63a4307b7be5eccc698b37c97fe9edc Cr-Commit-Position: refs/heads/master@{#376453} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/5a94b8b2e63a4307b7be5eccc698b37c97fe9edc Cr-Commit-Position: refs/heads/master@{#376453} |