Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1716713003: Refactor ScrollAnimatorMac to use CancellableTaskFactory (Closed)

Created:
4 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, kinuko+watch, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor ScrollAnimatorMac to use CancellableTaskFactory Refactor ScrollAnimatorMac to use CancellableTaskFactory because the unittests trigger ScrollAnimatorMac::sendContentAreaScrolledSoon which causes an assert (TestingPlatformMockWebTaskRunner:: monotonicallyIncreasingVirtualTimeSeconds is called) to fire after https://codereview.chromium.org/1646583002 lands. Changing over to CancellableTaskFactory means we can bypass the assert. BUG=546953 Committed: https://crrev.com/5a94b8b2e63a4307b7be5eccc698b37c97fe9edc Cr-Commit-Position: refs/heads/master@{#376453}

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Fix compile #

Patch Set 4 : Need to implement TestingPlatformMockWebTaskRunner::clone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 1 5 chunks +14 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 41 (23 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/1
4 years, 10 months ago (2016-02-19 11:04:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/20001
4 years, 10 months ago (2016-02-19 11:16:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/40001
4 years, 10 months ago (2016-02-19 11:28:20 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/161619)
4 years, 10 months ago (2016-02-19 11:43:06 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/60001
4 years, 10 months ago (2016-02-19 11:45:19 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/80001
4 years, 10 months ago (2016-02-19 11:55:24 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/100001
4 years, 10 months ago (2016-02-19 12:07:10 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/120001
4 years, 10 months ago (2016-02-19 12:15:50 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/140001
4 years, 10 months ago (2016-02-19 12:25:00 UTC) #23
alex clarke (OOO till 29th)
Please take a look.
4 years, 10 months ago (2016-02-19 12:26:37 UTC) #25
haraken
LGTM
4 years, 10 months ago (2016-02-19 12:30:29 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/140001
4 years, 10 months ago (2016-02-19 12:33:42 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/182605)
4 years, 10 months ago (2016-02-19 13:41:15 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/160001
4 years, 10 months ago (2016-02-19 14:23:24 UTC) #33
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 15:29:07 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716713003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716713003/160001
4 years, 10 months ago (2016-02-19 16:10:20 UTC) #38
commit-bot: I haz the power
Committed patchset #4 (id:160001)
4 years, 10 months ago (2016-02-19 16:20:55 UTC) #39
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 16:22:14 UTC) #41
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5a94b8b2e63a4307b7be5eccc698b37c97fe9edc
Cr-Commit-Position: refs/heads/master@{#376453}

Powered by Google App Engine
This is Rietveld 408576698