Issue 17167002: Fix Runtime_SetProperty to properly handle OOM failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17167002: Fix Runtime_SetProperty to properly handle OOM failures (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow

Modified:
7 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Runtime_SetProperty to properly handle OOM failures BUG=chromium:249873 R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15186

Patch Set 2 : addressed comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -10 lines)			Patch
	M	src/objects.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/runtime.cc	View	1	1 chunk	+24 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/17167002/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/17167002/diff/1/src/runtime.cc#newcode4757 src/runtime.cc:4757: if (!value->IsSmi() && !value->IsHeapNumber() && !value->IsUndefined()) ...

7 years, 6 months ago (2013-06-17 11:30:29 UTC) #1

Jakob Kummerow

Thanks for the review. I've updated the corresponding check in the handlified JSObject::SetElement too. https://codereview.chromium.org/17167002/diff/1/src/runtime.cc ...

7 years, 6 months ago (2013-06-17 16:50:28 UTC) #2

Jakob Kummerow

7 years, 6 months ago (2013-06-17 17:42:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15186 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17167002: Fix Runtime_SetProperty to properly handle OOM failures (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comments #

Messages