third_party/WebKit/Source/core/animation/Animation.h - Issue 1716673002: Web Animations: Throw exceptions for play/pause/reverse/finish with infinite end time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Animation.h

Issue 1716673002: Web Animations: Throw exceptions for play/pause/reverse/finish with infinite end time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/web-animations-api/infinite-end-time.html ('k') | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/Animation.h

diff --git a/third_party/WebKit/Source/core/animation/Animation.h b/third_party/WebKit/Source/core/animation/Animation.h

index 4b274761c4d3b8f528a965e54c8a3d67f180c9c2..d81e1954bea9d56ce518139c43f13e05ecfc1b3d 100644

--- a/third_party/WebKit/Source/core/animation/Animation.h

+++ b/third_party/WebKit/Source/core/animation/Animation.h

@@ -31,6 +31,7 @@

#ifndef Animation_h

#define Animation_h

+#include "bindings/core/v8/ExceptionStatePlaceholder.h"

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptPromiseProperty.h"

#include "core/CSSPropertyNames.h"

@@ -97,10 +98,10 @@ public:

String playState() const { return playStateString(playStateInternal()); }

AnimationPlayState playStateInternal() const;

- void pause();

- void play();

- void reverse();

- void finish(ExceptionState&);

+ void pause(ExceptionState& = ASSERT_NO_EXCEPTION);

+ void play(ExceptionState& = ASSERT_NO_EXCEPTION);

+ void reverse(ExceptionState& = ASSERT_NO_EXCEPTION);

+ void finish(ExceptionState& = ASSERT_NO_EXCEPTION);

ScriptPromise finished(ScriptState*);

ScriptPromise ready(ScriptState*);