chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc - Issue 1716653002: Implement OverlayPanels as SceneOverlays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

Issue 1716653002: Implement OverlayPanels as SceneOverlays (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Prevent native call in test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

diff --git a/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc b/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

index 606e2653bfb28ed3b30d30942ba281b0f770fa26..655225c40d2ed5806859c2704b67d55e4f516bed 100644

--- a/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

+++ b/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

@@ -31,22 +31,6 @@ TabListSceneLayer::TabListSceneLayer(JNIEnv* env, jobject jobj)

TabListSceneLayer::~TabListSceneLayer() {

}

-void TabListSceneLayer::SetContentTree(

- JNIEnv* env,

- const JavaParamRef<jobject>& jobj,

- const JavaParamRef<jobject>& jcontent_tree) {

- SceneLayer* content_tree = FromJavaObject(env, jcontent_tree);

- if (content_tree && content_tree->layer()) {

- content_tree_ = content_tree->layer();

- } else {

- content_tree_->RemoveFromParent();

- content_tree_ = nullptr;

- }

- if (content_tree_.get())

- layer()->AddChild(content_tree_);

void TabListSceneLayer::BeginBuildingFrame(JNIEnv* env,

const JavaParamRef<jobject>& jobj) {

write_index_ = 0;