chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java - Issue 1716653002: Implement OverlayPanels as SceneOverlays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

Issue 1716653002: Implement OverlayPanels as SceneOverlays (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Prevent native call in test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelHost.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

index 2c4cd8d81287f5b9a9e1551bb28918b162a44937..553cb261a484fd8735cb97ad57cb08e46d9f9f94 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

@@ -276,7 +276,8 @@ abstract class OverlayPanelBase {

}

/**

- * @return Whether the Overlay Panel is opened. That is, whether it is EXPANDED or MAXIMIZED.

+ * @return Whether the Overlay Panel is opened. That is, whether the current height is greater

+ * than the peeking height.

public boolean isPanelOpened() {

return mHeight > mBarHeightPeeking;

@@ -491,8 +492,8 @@ abstract class OverlayPanelBase {

// Base Page states

// --------------------------------------------------------------------------------------------

- private float mBasePageY;

- private float mBasePageBrightness;

+ private float mBasePageY = 0.0f;

+ private float mBasePageBrightness = 1.0f;

/**

* @return The vertical offset of the base page.