Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2635)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java

Issue 1716653002: Implement OverlayPanels as SceneOverlays (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java
index 6e8f2f48523c0361422b9b8d889732dbca01fc0d..0ac078eac091e5b3f7bbeb228fab5cb8dc0817dc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java
@@ -47,9 +47,6 @@ public class OverlayPanelManager {
/** When a panel is suppressed, this the reason the pending panel is to be shown. */
private StateChangeReason mPendingReason;
- /** This handles communication between each panel and it's host layout. */
- private OverlayPanelHost mOverlayPanelHost;
-
/** This handles resource loading for each panels. */
private DynamicResourceLoader mDynamicResourceLoader;
@@ -149,23 +146,11 @@ public class OverlayPanelManager {
mSuppressedPanel = null;
// Clear references to held resources.
- mOverlayPanelHost = null;
mDynamicResourceLoader = null;
mContainerViewGroup = null;
}
/**
- * Set the panel host for all OverlayPanels.
- * @param host The OverlayPanel host.
- */
- public void setPanelHost(OverlayPanelHost host) {
- mOverlayPanelHost = host;
- for (OverlayPanel p : mPanelSet) {
- p.setHost(host);
- }
- }
-
- /**
* Set the resource loader for all OverlayPanels.
* @param host The OverlayPanel host.
*/
@@ -188,17 +173,6 @@ public class OverlayPanelManager {
}
/**
- * Send size change event to all panels.
- * @param width The new width.
- * @param height The new height.
- */
- public void onSizeChanged(float width, float height) {
- for (OverlayPanel p : mPanelSet) {
- p.onSizeChanged(width, height);
- }
- }
-
- /**
* Add a panel to the collection that is managed by this class. If any of the setters for this
* class were called before a panel was added, that panel will still get those resources.
* @param panel An OverlayPanel to be managed.
@@ -206,9 +180,6 @@ public class OverlayPanelManager {
public void registerPanel(OverlayPanel panel) {
// If any of the setters for this manager were called before some panel registration,
// make sure that panel gets the appropriate resources.
- if (mOverlayPanelHost != null) {
- panel.setHost(mOverlayPanelHost);
- }
if (mDynamicResourceLoader != null) {
panel.setDynamicResourceLoader(mDynamicResourceLoader);
}

Powered by Google App Engine
This is Rietveld 408576698