chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java - Issue 1716653002: Implement OverlayPanels as SceneOverlays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

Issue 1716653002: Implement OverlayPanels as SceneOverlays (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromeTablet.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

index aaa12a028fb4eed46f509b1aa6b5992d3da7e7da..055544b87da36f865645f23df8475019ef3be32c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

@@ -117,7 +117,8 @@ public class LayoutManagerChromePhone extends LayoutManagerChrome {

@Override

protected void tabCreating(int sourceId, String url, boolean isIncognito) {

- if (!getActiveLayout().isHiding() && getActiveLayout().handlesTabCreating()) {

+ if (!getActiveLayout().isHiding() && (getActiveLayout().handlesTabCreating()

+ || getActiveLayout().isTabCreatingIntercepted())) {

// If the current layout in the foreground, let it handle the tab creation animation.

// This check allows us to switch from the StackLayout to the SimpleAnimationLayout

// smoothly.