Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1716633002: Remove XFA_DATAMERGE_UPDATEBINDINGRELATIONS_DFS (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove XFA_DATAMERGE_UPDATEBINDINGRELATIONS_DFS Doing so removes another CFX_PtrList usage. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/490543247e07ce1c92f609bcc2fa484652a86e1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -119 lines) Patch
M xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp View 3 chunks +1 line, -119 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, all red.
4 years, 10 months ago (2016-02-19 00:34:54 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-19 00:47:52 UTC) #3
Tom Sepez
4 years, 10 months ago (2016-02-19 17:14:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
490543247e07ce1c92f609bcc2fa484652a86e1f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698