Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1716543004: [turbofan] Fix ArchStackPointer properties for instruction scheduling. (Closed)

Created:
4 years, 10 months ago by baptiste.afsa1
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix ArchStackPointer properties for instruction scheduling. ArchStackPointer operation should not be reordered with respect to instructions which can modify the stack layout. R=jarin@chromium.org Committed: https://crrev.com/a33abf0bd8fe080636b13c32fcc6b591e8df95df Cr-Commit-Position: refs/heads/master@{#34151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/compiler/instruction-scheduler.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
baptiste.afsa1
PTAL
4 years, 10 months ago (2016-02-19 11:27:13 UTC) #1
Jarin
lgtm
4 years, 10 months ago (2016-02-19 11:47:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716543004/1
4 years, 10 months ago (2016-02-19 12:01:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 12:30:53 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 12:31:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a33abf0bd8fe080636b13c32fcc6b591e8df95df
Cr-Commit-Position: refs/heads/master@{#34151}

Powered by Google App Engine
This is Rietveld 408576698