ozone: Use allow_circular_includes_from to fix deps issue

ozone: Use allow_circular_includes_from to fix deps issue

It turns out what we're doing is supported all along with the special
allow_circular_includes_from feature. This says that the stuff in
platform/ is intended solely to be aggregated into //ui/ozone and it's
therefore OK to include headers from there. So switch to this instead of
annotating with "nogncheck."

Also add a bunch of missing dependencies that gn check is complaining
about, and fix public_deps of //ui/ozone to correctly include all of the
stuff needed by the public headers.

Committed: https://crrev.com/b4e50a86e213484d38735e7e930930a6eed74951
Cr-Commit-Position: refs/heads/master@{#376794}

[spang, 2016-02-19 02:44:17]

spang@chromium.org changed reviewers:
+ rjkroege@chromium.org

[spang, 2016-02-19 04:21:15]

Description was changed from

==========
ozone: Use allow_circular_includes_from to fix deps issue

It turns out what we're doing is supported all along with the special
allow_circular_includes_from feature. This says that the stuff in
platform/ is intended solely to be aggregated into //ui/ozone and it's
therefore OK to include headers from there. So switch to this instead of
annotating everything with "nogncheck."

Also add a bunch of missing dependencies that gn check is complaining
about, and fix public_deps of //ui/ozone to correctly include all of the
stuff needed by the public headers.
==========

to

==========
ozone: Use allow_circular_includes_from to fix deps issue

It turns out what we're doing is supported all along with the special
allow_circular_includes_from feature. This says that the stuff in
platform/ is intended solely to be aggregated into //ui/ozone and it's
therefore OK to include headers from there. So switch to this instead of
annotating with "nogncheck."

Also add a bunch of missing dependencies that gn check is complaining
about, and fix public_deps of //ui/ozone to correctly include all of the
stuff needed by the public headers.
==========

[rjkroege, 2016-02-19 19:00:53]

lgtm

https://codereview.chromium.org/1716543003/diff/20001/ui/ozone/BUILD.gn
File ui/ozone/BUILD.gn (right):

https://codereview.chromium.org/1716543003/diff/20001/ui/ozone/BUILD.gn#newco...
ui/ozone/BUILD.gn:162: # TODO(GYP) the GYP version has a way to add additional
dependencies via
So, can we add additional platforms from an external tree and still build with
GN?

[spang, 2016-02-22 19:27:13]

https://codereview.chromium.org/1716543003/diff/20001/ui/ozone/BUILD.gn
File ui/ozone/BUILD.gn (right):

https://codereview.chromium.org/1716543003/diff/20001/ui/ozone/BUILD.gn#newco...
ui/ozone/BUILD.gn:162: # TODO(GYP) the GYP version has a way to add additional
dependencies via
On 2016/02/19 19:00:53, rjkroege wrote:
> So, can we add additional platforms from an external tree and still build with
> GN?

Might be possible to do it via gn args. Nobody has looked into it really.

[spang, 2016-02-22 19:37:19]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2016-02-22 19:41:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716543003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716543003/20001

[commit-bot: I haz the power, 2016-02-22 20:21:39]

Description was changed from

==========
ozone: Use allow_circular_includes_from to fix deps issue

It turns out what we're doing is supported all along with the special
allow_circular_includes_from feature. This says that the stuff in
platform/ is intended solely to be aggregated into //ui/ozone and it's
therefore OK to include headers from there. So switch to this instead of
annotating with "nogncheck."

Also add a bunch of missing dependencies that gn check is complaining
about, and fix public_deps of //ui/ozone to correctly include all of the
stuff needed by the public headers.
==========

to

==========
ozone: Use allow_circular_includes_from to fix deps issue

It turns out what we're doing is supported all along with the special
allow_circular_includes_from feature. This says that the stuff in
platform/ is intended solely to be aggregated into //ui/ozone and it's
therefore OK to include headers from there. So switch to this instead of
annotating with "nogncheck."

Also add a bunch of missing dependencies that gn check is complaining
about, and fix public_deps of //ui/ozone to correctly include all of the
stuff needed by the public headers.
==========

[commit-bot: I haz the power, 2016-02-22 20:21:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-22 20:22:45]

Description was changed from

==========
ozone: Use allow_circular_includes_from to fix deps issue

It turns out what we're doing is supported all along with the special
allow_circular_includes_from feature. This says that the stuff in
platform/ is intended solely to be aggregated into //ui/ozone and it's
therefore OK to include headers from there. So switch to this instead of
annotating with "nogncheck."

Also add a bunch of missing dependencies that gn check is complaining
about, and fix public_deps of //ui/ozone to correctly include all of the
stuff needed by the public headers.
==========

to

==========
ozone: Use allow_circular_includes_from to fix deps issue

It turns out what we're doing is supported all along with the special
allow_circular_includes_from feature. This says that the stuff in
platform/ is intended solely to be aggregated into //ui/ozone and it's
therefore OK to include headers from there. So switch to this instead of
annotating with "nogncheck."

Also add a bunch of missing dependencies that gn check is complaining
about, and fix public_deps of //ui/ozone to correctly include all of the
stuff needed by the public headers.

Committed: https://crrev.com/b4e50a86e213484d38735e7e930930a6eed74951
Cr-Commit-Position: refs/heads/master@{#376794}
==========

[commit-bot: I haz the power, 2016-02-22 20:22:45]

Patchset 2 (id:??) landed as
https://crrev.com/b4e50a86e213484d38735e7e930930a6eed74951
Cr-Commit-Position: refs/heads/master@{#376794}