Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: build/common.gypi

Issue 1716543002: Enable browser hang reports for a day (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 86cb0791ea0d30b97bb3d83b683218804458c977..3dfcc903339b9690a9ead53242d2b2c520cdf1d9 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -487,12 +487,6 @@
# See https://github.com/google/syzygy/wiki/SyzyASanHowTo
'syzyasan%': 0,
- # Enable crash reporting via Kasko.
- 'kasko%': 0,
-
- # Enable hang reports in Kasko. Requires Kasko to be enabled.
- 'kasko_hang_reports%': 0,
-
# Enable building with LSan (Clang's -fsanitize=leak option).
# -fsanitize=leak only works with clang, but lsan=1 implies clang=1
# See https://sites.google.com/a/chromium.org/dev/developers/testing/leaksanitizer
@@ -1056,8 +1050,19 @@
# http://crbug.com/574476
'fastbuild%': 2,
}],
+
+ # Enable crash reporting via Kasko.
+ # TODO(pmonette): Remove browser hang reports within a day (2/19/2016).
+ ['OS=="win" and target_arch=="ia32" and branding=="Chrome"', {
+ 'kasko%': 1,
+ }, {
+ 'kasko%': 0,
+ }],
],
+ # Enable hang reports in Kasko. Requires Kasko to be enabled.
+ 'kasko_hang_reports%': 1,
+
# Setting this to '0' will cause V8's startup snapshot to be
# embedded in the binary instead of being a external files.
'v8_use_external_startup_data%': 1,
@@ -2007,6 +2012,8 @@
}],
['syzyasan==1', {
'kasko%': 1,
+ # Disable hang reports for SyzyASAN builds.
+ 'kasko_hang_reports': 0,
}],
['component=="shared_library" and "<(GENERATOR)"=="ninja"', {
# Only enabled by default for ninja because it's buggy in VS.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698