src/codec/SkJpegCodec.h - Issue 1716523002: Update Skia's YUV API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkJpegCodec.h

Issue 1716523002: Update Skia's YUV API (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Tweak the API to use arrays and named indices Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkJpegCodec.h

diff --git a/src/codec/SkJpegCodec.h b/src/codec/SkJpegCodec.h

index 06685cfd4c71a5bf9ab6ea523060be4b65f43558..fabaa0e8857fd4a4fc6639c6bbb4c1bc4f0dbe96 100644

--- a/src/codec/SkJpegCodec.h

+++ b/src/codec/SkJpegCodec.h

@@ -45,9 +45,10 @@ protected:

Result onGetPixels(const SkImageInfo& dstInfo, void* dst, size_t dstRowBytes, const Options&,

SkPMColor*, int*, int*) override;

- bool onQueryYUV8(YUVSizeInfo* sizeInfo, SkYUVColorSpace* colorSpace) const override;

+ bool onQueryYUV8(SkYUVSizeInfo* sizeInfo, SkYUVColorSpace* colorSpace) const override;

- Result onGetYUV8Planes(const YUVSizeInfo& sizeInfo, void* pixels[3]) override;

+ Result onGetYUV8Planes(const SkYUVSizeInfo& sizeInfo,

+ void* pixels[SkYUVSizeInfo::kPlaneCount]) override;

SkEncodedFormat onGetEncodedFormat() const override {

return kJPEG_SkEncodedFormat;