Update Skia's YUV API

Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716523002

Committed: https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f

Committed: https://skia.googlesource.com/skia/+/4984c3c95f18eda44492a2126c9958e447f2cca8

[msarett, 2016-02-18 22:00:26]

Description was changed from

==========
YUV madness

BUG=skia:
==========

to

==========
YUV madness

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-02-18 22:05:00]

Patchset #1 (id:1) has been deleted

[msarett, 2016-02-18 22:19:55]

Patchset #2 (id:40001) has been deleted

[msarett, 2016-02-18 22:20:02]

Patchset #1 (id:20001) has been deleted

[msarett, 2016-02-18 22:35:27]

Patchset #1 (id:60001) has been deleted

[msarett, 2016-02-18 22:51:40]

Description was changed from

==========
YUV madness

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-02-18 23:00:01]

msarett@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com, scroggo@google.com

[msarett, 2016-02-18 23:00:02]

Once we're happy with this, I'll start work on the Chromium changes that go
along with it.

I think this CL might suggest one or two more API tweaks.

https://codereview.chromium.org/1716523002/diff/80001/src/core/SkYUVPlanesCac...
File src/core/SkYUVPlanesCache.h (right):

https://codereview.chromium.org/1716523002/diff/80001/src/core/SkYUVPlanesCac...
src/core/SkYUVPlanesCache.h:26: struct Info {
Instead of having this struct (in addition to SkYUVSizeInfo), perhaps we should
have a single struct (SkYUVInfo) that contains all of this and is used by
everyone?

https://codereview.chromium.org/1716523002/diff/80001/src/gpu/GrYUVProvider.cpp
File src/gpu/GrYUVProvider.cpp (left):

https://codereview.chromium.org/1716523002/diff/80001/src/gpu/GrYUVProvider.c...
src/gpu/GrYUVProvider.cpp:94: for (int i = 0; i < 3; ++i) {
The fact that I needed to unroll this loop makes an argument for fSizes[3]
instead of having fYSize, fUSize, and fVSize.

But I would lean toward fYSize, fUSize, and fVSize.  Notice that unrolling the
loop allows us to treat U and V slightly differently from Y.

https://codereview.chromium.org/1716523002/diff/80001/src/gpu/GrYUVProvider.cpp
File src/gpu/GrYUVProvider.cpp (right):

https://codereview.chromium.org/1716523002/diff/80001/src/gpu/GrYUVProvider.c...
src/gpu/GrYUVProvider.cpp:156: &yuvInfo.fSizeInfo.fYSize,
Nobody look here.  This line isn't hacky at all. :)

[reed1, 2016-02-19 20:03:53]

lets consider using arrays, with an enum so clients can use named indices if
they wish...

[msarett, 2016-02-19 21:35:33]

PTAL

I've changed the API to use arrays with named indices.

[scroggo, 2016-02-19 21:54:13]

On 2016/02/19 21:35:33, msarett wrote:
> PTAL
> 
> I've changed the API to use arrays with named indices.

I think the interesting thing to look at is SkYUVSizeInfo.h? lgtm

[reed1, 2016-02-19 22:00:24]

api lgtm w/ nit/request for (re)moving the Count enum value.

https://codereview.chromium.org/1716523002/diff/100001/include/core/SkYUVSize...
File include/core/SkYUVSizeInfo.h (right):

https://codereview.chromium.org/1716523002/diff/100001/include/core/SkYUVSize...
include/core/SkYUVSizeInfo.h:16: kPlaneCount = 3,
nit: In general we have shied away from placing the "count" in the same enum as
"indices", since its slightly suggestive of a client using it as an index!

Personally I think its fine to just use [3] here, since YUV isn't going to
change EVER. If you prefer a named value, how about a separate enum somewhere,
so it is visually separate from Y U V...?

[msarett, 2016-02-19 22:16:12]

https://codereview.chromium.org/1716523002/diff/100001/include/core/SkYUVSize...
File include/core/SkYUVSizeInfo.h (right):

https://codereview.chromium.org/1716523002/diff/100001/include/core/SkYUVSize...
include/core/SkYUVSizeInfo.h:16: kPlaneCount = 3,
On 2016/02/19 22:00:23, reed1 wrote:
> nit: In general we have shied away from placing the "count" in the same enum
as
> "indices", since its slightly suggestive of a client using it as an index!
> 
> Personally I think its fine to just use [3] here, since YUV isn't going to
> change EVER. If you prefer a named value, how about a separate enum somewhere,
> so it is visually separate from Y U V...?

Makes sense.  No reason not to just use 3 :).

[msarett, 2016-02-23 16:13:10]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 16:13:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716523002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716523002/120001

[commit-bot: I haz the power, 2016-02-23 16:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:14:06]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7...)
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[msarett, 2016-02-23 16:20:24]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 16:20:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716523002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716523002/140001

[commit-bot: I haz the power, 2016-02-23 16:45:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:45:31]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-03-07 14:56:18]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 14:56:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716523002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716523002/160001

[commit-bot: I haz the power, 2016-03-07 15:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 15:07:18]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-03-07 16:37:50]

The CQ bit was checked by msarett@google.com

[msarett, 2016-03-07 16:37:50]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1716523002/#ps160001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-07 16:37:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716523002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716523002/160001

[commit-bot: I haz the power, 2016-03-07 16:39:15]

Description was changed from

==========
Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f
==========

[commit-bot: I haz the power, 2016-03-07 16:39:16]

Committed patchset #5 (id:160001) as
https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f

[msarett, 2016-03-07 17:16:36]

A revert of this CL (patchset #5 id:160001) has been created in
https://codereview.chromium.org/1775493002/ by msarett@google.com.

The reason for reverting is: Blimp failures with manual roll in Chrome..

[msarett, 2016-03-08 00:35:05]

Description was changed from

==========
Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f
==========

to

==========
Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f
==========

[msarett, 2016-03-10 13:26:20]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-03-10 13:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716523002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716523002/160001

[commit-bot: I haz the power, 2016-03-10 13:44:46]

Description was changed from

==========
Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f
==========

to

==========
Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f

Committed:
https://skia.googlesource.com/skia/+/4984c3c95f18eda44492a2126c9958e447f2cca8
==========

[commit-bot: I haz the power, 2016-03-10 13:44:47]

Committed patchset #5 (id:160001) as
https://skia.googlesource.com/skia/+/4984c3c95f18eda44492a2126c9958e447f2cca8