media/blink/websourcebuffer_impl.cc - Issue 1716503002: Basic media tracks implementation for media stream parsers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/websourcebuffer_impl.cc

Issue 1716503002: Basic media tracks implementation for media stream parsers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/websourcebuffer_impl.cc

diff --git a/media/blink/websourcebuffer_impl.cc b/media/blink/websourcebuffer_impl.cc

index ffb62c5c5397918a608726aad42fa17be555eb1e..f4b3b22c8dd47645c27998e8a8b528366994e0fe 100644

--- a/media/blink/websourcebuffer_impl.cc

+++ b/media/blink/websourcebuffer_impl.cc

@@ -12,6 +12,7 @@

#include "base/bind.h"

#include "base/callback.h"

#include "base/callback_helpers.h"

+#include "media/base/media_tracks.h"

#include "media/base/timestamp_constants.h"

#include "media/filters/chunk_demuxer.h"

#include "third_party/WebKit/public/platform/WebSourceBufferClient.h"

@@ -158,8 +159,9 @@ void WebSourceBufferImpl::removedFromMediaSource() {

client_ = NULL;

}

-void WebSourceBufferImpl::InitSegmentReceived() {

+void WebSourceBufferImpl::InitSegmentReceived(const MediaTracks& tracks) {

DVLOG(1) << __FUNCTION__;

+ // TODO(servolk): Implement passing MediaTrack info to blink level.

wolenetz 2016/02/26 19:29:28 really minor nit: TODO needs crbug reference. I su

servolk 2016/02/26 22:02:41 Done.

client_->initializationSegmentReceived();

}

« no previous file with comments | « media/blink/websourcebuffer_impl.h ('k') | media/filters/chunk_demuxer_unittest.cc » ('j') | media/formats/mpeg/mpeg_audio_stream_parser_base.cc » ('J')