Basic media tracks implementation for media stream parsers

media/base/media_track.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[wolenetz, 2016/02/26 00:59:41]

nit: here and elsewhere in the new files, no (c) these days...
(https://www.chromium.org/developers/coding-style)

[servolk, 2016/02/26 01:56:31]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_MEDIA_TRACK_H_
+#define MEDIA_BASE_MEDIA_TRACK_H_
+
+#include <string>
+
+#include "media/base/media_export.h"
+
+namespace media {
+
+class MEDIA_EXPORT MediaTrack {
+ public:
+  enum Type { Text, Audio, Video };
+  MediaTrack(Type type,
+             const std::string& id,
+             const std::string& kind,
+             const std::string& label,
+             const std::string& lang);
+  virtual ~MediaTrack();

[wolenetz, 2016/02/26 00:06:20]

Is this class meant to be subtyped? Do we need virtual destructor? Is this a
partial interface?

[servolk, 2016/02/26 01:56:31]

This class is essentially a Chromium-level counterpart for blink::TrackBase, it
contains the same set of properties. On blink level they derive
AudioTrack/VideoTrack from TrackBase (to add AudioTrack.enabled and
VideoTrack.selected properties). So I think that yes, later on this will be a
base class for actual a/v/t tracks, that's why I added the virtual destructor.
But right now it's not needed, so removing the 'virtual' for now.

[wolenetz, 2016/02/26 19:29:27]

Acknowledged.

+
+  Type type() const { return type_; }
+
+  const std::string& id() const { return id_; }
+  const std::string& kind() const { return kind_; }
+  const std::string& label() const { return label_; }
+  const std::string& language() const { return language_; }
+
+ private:
+  Type type_;
+  std::string id_;
+  std::string kind_;
+  std::string label_;
+  std::string language_;
+};
+
+}  // namespace media
+
+#endif  // MEDIA_BASE_MEDIA_TRACK_H_