Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: chrome/browser/webview/webview_guest.h

Issue 17165004: <webview>: Partially migrate loadcommit event from content to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webview/webview_constants.cc ('k') | chrome/browser/webview/webview_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webview/webview_guest.h
diff --git a/chrome/browser/webview/webview_guest.h b/chrome/browser/webview/webview_guest.h
index cefc7b335a496ac5708a65bdec7daaf3abd142d1..da406a0bf170b2f6b9b9dd40a96ed823ce47a1dd 100644
--- a/chrome/browser/webview/webview_guest.h
+++ b/chrome/browser/webview/webview_guest.h
@@ -13,8 +13,6 @@ namespace extensions {
class ScriptExecutor;
} // namespace extensions
-namespace chrome {
-
// A WebViewGuest is a WebContentsObserver on the guest WebContents of a
// <webview> tag. It provides the browser-side implementation of the <webview>
// API and manages the lifetime of <webview> extension events. WebViewGuest is
@@ -48,6 +46,16 @@ class WebViewGuest : public content::WebContentsObserver {
private:
virtual ~WebViewGuest();
+
+ void DispatchEvent(const std::string& event_name,
+ scoped_ptr<DictionaryValue> event);
+
+ virtual void DidCommitProvisionalLoadForFrame(
+ int64 frame_id,
+ bool is_main_frame,
+ const GURL& url,
+ content::PageTransition transition_type,
+ content::RenderViewHost* render_view_host) OVERRIDE;
virtual void WebContentsDestroyed(
content::WebContents* web_contents) OVERRIDE;
@@ -75,6 +83,4 @@ class WebViewGuest : public content::WebContentsObserver {
DISALLOW_COPY_AND_ASSIGN(WebViewGuest);
};
-} // namespace chrome
-
#endif // CHROME_BROWSER_WEBVIEW_WEBVIEW_GUEST_H_
« no previous file with comments | « chrome/browser/webview/webview_constants.cc ('k') | chrome/browser/webview/webview_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698