chrome/browser/extensions/api/webview/webview_api_constants.cc - Issue 17165004: <webview>: Partially migrate loadcommit event from content to chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/webview/webview_api_constants.cc

Issue 17165004: <webview>: Partially migrate loadcommit event from content to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lazyboy@'s comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser//extensions/api/webview/webview_api_constants.h"

	6

	7 namespace webview_api_constants {

	8

	9 // Events.

	10 const char kEventLoadCommit[] = "loadcommit";
	Matt Perry 2013/06/19 22:47:50 nit: capitalize the event name for consistency. A nit: capitalize the event name for consistency. Also, please make this const the whole event string, "webview.onLoadCommit". Fady Samuel 2013/06/20 00:26:56 Done. Show quoted text On 2013/06/19 22:47:50, Matt Perry wrote: > nit: capitalize the event name for consistency. > > Also, please make this const the whole event string, "webview.onLoadCommit". Done.
	11

	12 // Parameters/properties on events.

	13 const char kIsTopLevel[] = "isTopLevel";

	14 const char kUrl[] = "url";

	15

	16 } // namespace webview_api_constants

OLD	NEW

« no previous file with comments | « chrome/browser/extensions/api/webview/webview_api_constants.h ('k') | chrome/browser/webview/webview_guest.h » ('j') | no next file with comments »