base/logging.h - Issue 17165003: allow unofficial builds with DCHECK and DLOG disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 17165003: allow unofficial builds with DCHECK and DLOG disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index 55c9ebfafbf3db7f44419145bcb486073fff6e88..891f6756be9c3faa07aa368202b77f05efe19288 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -447,11 +447,13 @@ const LogSeverity LOG_0 = LOG_ERROR;

#define PLOG_IF(severity, condition) \

LAZY_STREAM(PLOG_STREAM(severity), LOG_IS_ON(severity) && (condition))

+#if !defined(LOGGING_IS_OFFICIAL_BUILD)

#if defined(OFFICIAL_BUILD) && defined(NDEBUG)

#define LOGGING_IS_OFFICIAL_BUILD 1

#else

#define LOGGING_IS_OFFICIAL_BUILD 0

#endif

+#endif

// The actual stream used isn't important.

#define EAT_STREAM_PARAMETERS \

« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')