Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1716493002: Enable gesture events for wheel events on all platforms other that OSX. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
skobes, tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam, ymalik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_wheel_passive_listeners_4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable gesture events for wheel events on all platforms other that OSX. OSX has some remaining bugs to deal with overscroll for gesture events but enable it everywhere else. BUG=568183 Committed: https://crrev.com/e552e8a9e51777b6579bbfaa0be8ceb58a57b70a Cr-Commit-Position: refs/heads/master@{#376604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/common/input/input_event_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
dtapuska
4 years, 10 months ago (2016-02-18 21:36:04 UTC) #3
tdresser
LGTM
4 years, 10 months ago (2016-02-19 14:53:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716493002/1
4 years, 10 months ago (2016-02-20 00:41:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-20 01:49:49 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e552e8a9e51777b6579bbfaa0be8ceb58a57b70a Cr-Commit-Position: refs/heads/master@{#376604}
4 years, 10 months ago (2016-02-20 01:50:44 UTC) #10
dtapuska
4 years, 10 months ago (2016-02-22 14:30:59 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1723513002/ by dtapuska@chromium.org.

The reason for reverting is: iframes were broken; will re-land once fixed.

Powered by Google App Engine
This is Rietveld 408576698