Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 171643002: Roll clang on Windows to r201612 for vdtor fix (Closed)

Created:
6 years, 10 months ago by Reid Kleckner
Modified:
6 years, 10 months ago
Reviewers:
hans
CC:
chromium-reviews
Visibility:
Public.

Description

Roll clang on Windows to r201612 for vdtor fix TBR=hans@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Reid Kleckner
6 years, 10 months ago (2014-02-18 23:40:10 UTC) #1
Reid Kleckner
The CQ bit was checked by rnk@chromium.org
6 years, 10 months ago (2014-02-18 23:51:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/171643002/1
6 years, 10 months ago (2014-02-18 23:52:13 UTC) #3
hans
I highly recommend NOTRY=true for these.
6 years, 10 months ago (2014-02-18 23:52:16 UTC) #4
Reid Kleckner
The CQ bit was unchecked by rnk@chromium.org
6 years, 10 months ago (2014-02-18 23:54:14 UTC) #5
Reid Kleckner
The CQ bit was checked by rnk@chromium.org
6 years, 10 months ago (2014-02-18 23:54:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 02:40:07 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-19 02:40:08 UTC) #8
hans
The CQ bit was checked by hans@chromium.org
6 years, 10 months ago (2014-02-19 02:53:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/171643002/1
6 years, 10 months ago (2014-02-19 02:54:53 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 02:55:57 UTC) #11
Message was sent while issue was closed.
Change committed as 251940

Powered by Google App Engine
This is Rietveld 408576698