third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp - Issue 1716303002: Remove SecurityOrigin::isPotentiallyTrustworthy() |errorMessage|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

Issue 1716303002: Remove SecurityOrigin::isPotentiallyTrustworthy() |errorMessage| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp ('k') | third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp b/third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

index fce9c8ae0700c6f8cc3cb4fdb193665eebc1f6b9..559b177490193f43e87f92681d85ff6521a65f49 100644

--- a/third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebSecurityOrigin.cpp

@@ -126,9 +126,9 @@ bool WebSecurityOrigin::canRequest(const WebURL& url) const

bool WebSecurityOrigin::isPotentiallyTrustworthy(WebString& errorMessage) const

{

ASSERT(m_private);

- WTF::String message(errorMessage);

- bool result = m_private->isPotentiallyTrustworthy(message);

- errorMessage = message;

+ bool result = m_private->isPotentiallyTrustworthy();

+ if (!result)

+ errorMessage = WTF::String(m_private->isPotentiallyTrustworthyErrorMessage());

return result;

}