third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp - Issue 1716303002: Remove SecurityOrigin::isPotentiallyTrustworthy() |errorMessage|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

Issue 1716303002: Remove SecurityOrigin::isPotentiallyTrustworthy() |errorMessage| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp ('k') | third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

index 1cf09b6f3d6d73387cb88ccd4d3958187402814f..584e0fb6b7c07c69e901106f222b1da5d2acbda5 100644

--- a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

@@ -71,8 +71,10 @@ PassOwnPtr<WebServiceWorkerCacheStorage> assertCacheStorage(ErrorString* errorSt

RefPtr<SecurityOrigin> secOrigin = SecurityOrigin::createFromString(securityOrigin);

// Cache Storage API is restricted to trustworthy origins.

- if (!secOrigin->isPotentiallyTrustworthy(*errorString))

+ if (!secOrigin->isPotentiallyTrustworthy()) {

+ *errorString = secOrigin->isPotentiallyTrustworthyErrorMessage();

return nullptr;

+ }

String identifier = createDatabaseIdentifierFromSecurityOrigin(secOrigin.get());

OwnPtr<WebServiceWorkerCacheStorage> cache = adoptPtr(Platform::current()->cacheStorage(identifier));