Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1716273002: Add asm->wasmified version of embenchen. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add asm->wasmified version of embenchen. Adding a version of embenchen, modified to pass through the asm->wasm javascript interface. Disabling for now as fixes required to run it are outstanding. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/wasm/embenchen R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/fe2ed5667b79689332337035f4dc7c7e000c171e Cr-Commit-Position: refs/heads/master@{#34217}

Patch Set 1 #

Patch Set 2 : drop todo #

Total comments: 2

Patch Set 3 : readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -27 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/wasm/embenchen/README View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/box2d.js View 1 3 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/copy.js View 3 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/corrections.js View 3 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/fannkuch.js View 3 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/fasta.js View 3 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/lua_binarytrees.js View 3 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/memops.js View 3 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/primes.js View 3 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/wasm/embenchen/zlib.js View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bradn
4 years, 10 months ago (2016-02-22 17:51:58 UTC) #2
aseemgarg
https://codereview.chromium.org/1716273002/diff/20001/test/mjsunit/wasm/embenchen/copy.js File test/mjsunit/wasm/embenchen/copy.js (right): https://codereview.chromium.org/1716273002/diff/20001/test/mjsunit/wasm/embenchen/copy.js#newcode5775 test/mjsunit/wasm/embenchen/copy.js:5775: { "Math": Math, "Int8Array": Int8Array, "Int16Array": Int16Array, "Int32Array": Int32Array, ...
4 years, 10 months ago (2016-02-22 22:28:41 UTC) #3
bradn
https://codereview.chromium.org/1716273002/diff/20001/test/mjsunit/wasm/embenchen/copy.js File test/mjsunit/wasm/embenchen/copy.js (right): https://codereview.chromium.org/1716273002/diff/20001/test/mjsunit/wasm/embenchen/copy.js#newcode5775 test/mjsunit/wasm/embenchen/copy.js:5775: { "Math": Math, "Int8Array": Int8Array, "Int16Array": Int16Array, "Int32Array": Int32Array, ...
4 years, 10 months ago (2016-02-23 05:56:02 UTC) #4
bradnelson
Ah, just noticed this was missing the README I meant to include.
4 years, 10 months ago (2016-02-23 06:52:46 UTC) #5
titzer
On 2016/02/23 06:52:46, bradnelson wrote: > Ah, just noticed this was missing the README I ...
4 years, 10 months ago (2016-02-23 15:58:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716273002/40001
4 years, 10 months ago (2016-02-23 16:16:25 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-23 16:21:44 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 16:23:35 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe2ed5667b79689332337035f4dc7c7e000c171e
Cr-Commit-Position: refs/heads/master@{#34217}

Powered by Google App Engine
This is Rietveld 408576698