Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1716163003: [turbofan] Pick remembered set action for write barrier. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pick remembered set action for write barrier. This picks the record-write stub depending on the correct remembered set action parameter. For values known to be maps we can guarantee that they never reside in new-space, hence store buffer recording can be skipped. R=bmeurer@chromium.org Committed: https://crrev.com/119a23e113b2d622044eb447c2255e543be58897 Cr-Commit-Position: refs/heads/master@{#34191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
Benedikt: PTAL at the implementation. Ulan: Please verify my argumentation about GC semantics.
4 years, 10 months ago (2016-02-22 13:03:43 UTC) #2
Benedikt Meurer
LGTM!
4 years, 10 months ago (2016-02-22 13:16:38 UTC) #3
ulan
lgtm, the gc argumentation is correct.
4 years, 10 months ago (2016-02-22 13:17:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716163003/1
4 years, 10 months ago (2016-02-22 13:19:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 13:22:20 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 13:23:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/119a23e113b2d622044eb447c2255e543be58897
Cr-Commit-Position: refs/heads/master@{#34191}

Powered by Google App Engine
This is Rietveld 408576698