Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1716163002: include-what-you-use: Fix some tracing-related includes (Closed)

Created:
4 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, devtools-reviews_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, oshima+watch_chromium.org, pfeldman, phoglund+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, tnakamura+watch_chromium.org, tracing+reviews_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include-what-you-use: Fix some tracing-related includes Non-functional refactor. Some translation units use RefCounted* classes from ref_counted_memory.h without including the heaader. They rely on common tracing headers to include ref_counted_memory.h. This patch changes the relevant files to explicitly include that, as I am about to refactor tracing headers soon. BUG=559117 TBR=jochen@chromium.org, phajdan.jr@chromium.org Committed: https://crrev.com/30c5afa56ab693e54bf0f56d3c3c468afbe8e0a5 Cr-Commit-Position: refs/heads/master@{#376721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/test/trace_event_analyzer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/trace_to_file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
petrcermak
LGTM with three description nits: * s/Non functional/Non-functional*/ * s/and but include/without including/ * you ...
4 years, 10 months ago (2016-02-22 11:57:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716163002/1
4 years, 10 months ago (2016-02-22 12:03:09 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-22 14:15:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 14:37:17 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 14:38:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30c5afa56ab693e54bf0f56d3c3c468afbe8e0a5
Cr-Commit-Position: refs/heads/master@{#376721}

Powered by Google App Engine
This is Rietveld 408576698