Issue 171603015: Revert "Support viewport in content_shell."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171603015: Revert "Support viewport in content_shell." (Closed)

Created:
6 years, 10 months ago by Peter Beverloo

Modified:
6 years, 10 months ago

Reviewers:
aelias_OOO_until_Jul13, jochen (gone - plz use gerrit), zeeshankq

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Support viewport in content_shell." This patch changes layout tests on Android to be ran using a 980x735 canvas instead of an 800x600 one, basically breaking everything. The "WebKit Android (Nexus4)" tester is currently red because of this. > Support viewport in content_shell. > > Viewport preferences are overridden even with the --enable-viewport > flag passed in. > > BUG=343993 > BUG=343993, 345221 NOTRY=true TBR=zeeshankq@chromium.org, aelias, jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252234

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	content/shell/common/webkit_test_helpers.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/171603015/1

6 years, 10 months ago (2014-02-20 14:17:21 UTC) #2

Peter Beverloo

6 years, 10 months ago (2014-02-20 14:55:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r252234 (tree was closed).

Expand Messages | Collapse Messages