Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171603007: Allow form submission for forms with "hidden" for submit with enter key (Closed)

Created:
6 years, 10 months ago by spartha
Modified:
6 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Allow form submission for forms with "hidden" for submit with enter key Currently the forms are not submitted if the Submit button does not have a renderer. This patch removes that restriction. This also matches the behavior with Firefox & IE BUG=89586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167857

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Redid Layout testcases as per review #

Patch Set 4 : Missing text expectation file added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M LayoutTests/fast/forms/implicit-submission.html View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/implicit-submission-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/implicit-submission-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
spartha
6 years, 10 months ago (2014-02-20 16:59:55 UTC) #1
tkent
https://codereview.chromium.org/171603007/diff/40001/LayoutTests/fast/forms/form-submit-with-submit-type-display-none.html File LayoutTests/fast/forms/form-submit-with-submit-type-display-none.html (right): https://codereview.chromium.org/171603007/diff/40001/LayoutTests/fast/forms/form-submit-with-submit-type-display-none.html#newcode1 LayoutTests/fast/forms/form-submit-with-submit-type-display-none.html:1: <!DOCTYPE html> Would you add this to fast/forms/implicit-submission.html, or ...
6 years, 10 months ago (2014-02-21 00:48:46 UTC) #2
spartha
On 2014/02/21 00:48:46, tkent wrote: > https://codereview.chromium.org/171603007/diff/40001/LayoutTests/fast/forms/form-submit-with-submit-type-display-none.html > File LayoutTests/fast/forms/form-submit-with-submit-type-display-none.html > (right): > > https://codereview.chromium.org/171603007/diff/40001/LayoutTests/fast/forms/form-submit-with-submit-type-display-none.html#newcode1 ...
6 years, 10 months ago (2014-02-26 04:29:12 UTC) #3
tkent
lgtm
6 years, 10 months ago (2014-02-26 04:32:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/171603007/140001
6 years, 10 months ago (2014-02-26 04:39:09 UTC) #5
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 04:39:15 UTC) #6
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:30:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/171603007/140001
6 years, 10 months ago (2014-02-26 05:30:55 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 08:09:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 167857

Powered by Google App Engine
This is Rietveld 408576698