Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 1716023002: Fix draggable elements are painted at incorrect position (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove comment. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/EventHandler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 { 659 {
660 PaintInfo paintInfo(dragImageBuilder.context(), boundingBox, PaintPh ase::PaintPhaseForeground, GlobalPaintFlattenCompositingLayers, 0); 660 PaintInfo paintInfo(dragImageBuilder.context(), boundingBox, PaintPh ase::PaintPhaseForeground, GlobalPaintFlattenCompositingLayers, 0);
661 ObjectPainter(*layoutObject).paintAsPseudoStackingContext(paintInfo, LayoutPoint(paintOffset)); 661 ObjectPainter(*layoutObject).paintAsPseudoStackingContext(paintInfo, LayoutPoint(paintOffset));
662 } 662 }
663 return dragImageBuilder.createImage(); 663 return dragImageBuilder.createImage();
664 } 664 }
665 665
666 // TODO(pdr): This will also paint the background if the object contains tra nsparency. We can 666 // TODO(pdr): This will also paint the background if the object contains tra nsparency. We can
667 // directly call layoutObject->paint(...) (see: ObjectPainter::paintAsPseudo StackingContext) but 667 // directly call layoutObject->paint(...) (see: ObjectPainter::paintAsPseudo StackingContext) but
668 // painters are inconsistent about which transform space they expect (see: s vg, inlines, etc.) 668 // painters are inconsistent about which transform space they expect (see: s vg, inlines, etc.)
669 // TODO(pdr): SVG and inlines are painted offset (crbug.com/579153, crbug.co m/579158).
670 return paintIntoDragImage(GlobalPaintFlattenCompositingLayers, layoutObject- >absoluteBoundingBoxRectIncludingDescendants(), &node); 669 return paintIntoDragImage(GlobalPaintFlattenCompositingLayers, layoutObject- >absoluteBoundingBoxRectIncludingDescendants(), &node);
671 } 670 }
672 671
673 PassOwnPtr<DragImage> LocalFrame::dragImageForSelection(float opacity) 672 PassOwnPtr<DragImage> LocalFrame::dragImageForSelection(float opacity)
674 { 673 {
675 if (!selection().isRange()) 674 if (!selection().isRange())
676 return nullptr; 675 return nullptr;
677 676
678 m_view->updateAllLifecyclePhases(); 677 m_view->updateAllLifecyclePhases();
679 678
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
889 { 888 {
890 m_frame->disableNavigation(); 889 m_frame->disableNavigation();
891 } 890 }
892 891
893 FrameNavigationDisabler::~FrameNavigationDisabler() 892 FrameNavigationDisabler::~FrameNavigationDisabler()
894 { 893 {
895 m_frame->enableNavigation(); 894 m_frame->enableNavigation();
896 } 895 }
897 896
898 } // namespace blink 897 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/EventHandler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698