Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3589)

Unified Diff: chrome/browser/net/passive_log_collector.cc

Issue 1716007: Cleanup: Address some of the todos in net_log.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/net_internals_ui.cc ('k') | chrome/browser/net/passive_log_collector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/passive_log_collector.cc
===================================================================
--- chrome/browser/net/passive_log_collector.cc (revision 45472)
+++ chrome/browser/net/passive_log_collector.cc (working copy)
@@ -320,7 +320,7 @@
RequestInfo* connect_info = GetRequestInfo(connect_id);
if (!connect_info) {
net::NetLogStringParameter* text = new net::NetLogStringParameter(
- StringPrintf("Used ConnectJob id=%u", connect_id));
+ "todo", StringPrintf("Used ConnectJob id=%u", connect_id));
Entry new_entry(0, net::NetLog::TYPE_TODO_STRING, base::TimeTicks(),
net::NetLog::Source(net::NetLog::SOURCE_CONNECT_JOB,
connect_id),
@@ -383,7 +383,7 @@
RequestInfo* socket_info = GetRequestInfo(socket_id);
if (!socket_info) {
net::NetLogStringParameter* text = new net::NetLogStringParameter(
- StringPrintf("Used Socket id=%u.", socket_id));
+ "todo", StringPrintf("Used Socket id=%u.", socket_id));
Entry new_entry(0, net::NetLog::TYPE_TODO_STRING, base::TimeTicks(),
net::NetLog::Source(net::NetLog::SOURCE_SOCKET, socket_id),
net::NetLog::PHASE_NONE, text);
@@ -397,6 +397,7 @@
// Synthesize a log entry for bytes sent and received.
if (socket_info->bytes_transmitted > 0 || socket_info->bytes_received > 0) {
net::NetLogStringParameter* text = new net::NetLogStringParameter(
+ "stats",
StringPrintf("Tx/Rx: %"PRIu64"/%"PRIu64" [%"PRIu64"/%"PRIu64
" total on socket] (Bytes)",
socket_info->bytes_transmitted,
« no previous file with comments | « chrome/browser/dom_ui/net_internals_ui.cc ('k') | chrome/browser/net/passive_log_collector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698