Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: net/proxy/proxy_service.cc

Issue 1716007: Cleanup: Address some of the todos in net_log.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/init_proxy_resolver_unittest.cc ('k') | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_service.cc
===================================================================
--- net/proxy/proxy_service.cc (revision 45472)
+++ net/proxy/proxy_service.cc (working copy)
@@ -469,14 +469,15 @@
if (result_code == OK) {
// When full logging is enabled, dump the proxy list.
if (net_log.HasListener()) {
- net_log.AddString(
- std::string("Resolved proxy list: ") + result->ToPacString());
+ net_log.AddEventWithString(
+ NetLog::TYPE_PROXY_SERVICE_RESOLVED_PROXY_LIST,
+ "pac_string", result->ToPacString());
}
result->DeprioritizeBadProxies(proxy_retry_info_);
} else {
- net_log.AddString(StringPrintf(
- "Got an error from proxy resolver (%d), falling-back to DIRECT.",
- result_code));
+ net_log.AddEventWithInteger(
+ NetLog::TYPE_PROXY_SERVICE_RESOLVED_PROXY_LIST,
+ "net_error", result_code);
// Fall-back to direct when the proxy resolver fails. This corresponds
// with a javascript runtime error in the PAC script.
« no previous file with comments | « net/proxy/init_proxy_resolver_unittest.cc ('k') | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698