Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/browser/resources/net_internals/sourceentry.js

Issue 1716007: Cleanup: Address some of the todos in net_log.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * Each row in the filtered items list is backed by a SourceEntry. This 6 * Each row in the filtered items list is backed by a SourceEntry. This
7 * instance contains all of the data pertaining to that row, and notifies 7 * instance contains all of the data pertaining to that row, and notifies
8 * its parent view (the RequestsView) whenever its data changes. 8 * its parent view (the RequestsView) whenever its data changes.
9 * 9 *
10 * @constructor 10 * @constructor
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 // Add a CSS classname specific to this source type (so CSS can specify 149 // Add a CSS classname specific to this source type (so CSS can specify
150 // different stylings for different types). 150 // different stylings for different types).
151 changeClassName(this.row_, "source_" + sourceTypeString, true); 151 changeClassName(this.row_, "source_" + sourceTypeString, true);
152 }; 152 };
153 153
154 SourceEntry.prototype.getDescription = function() { 154 SourceEntry.prototype.getDescription = function() {
155 var e = this.getStartEntry_(); 155 var e = this.getStartEntry_();
156 if (!e || e.extra_parameters == undefined) 156 if (!e || e.extra_parameters == undefined)
157 return ''; 157 return '';
158 return e.extra_parameters; // The URL / hostname / whatever. 158 return JSON.stringify(e.extra_parameters); // The URL / hostname / whatever.
159 }; 159 };
160 160
161 /** 161 /**
162 * Returns the starting entry for this source. Conceptually this is the 162 * Returns the starting entry for this source. Conceptually this is the
163 * first entry that was logged to this source. However, we skip over the 163 * first entry that was logged to this source. However, we skip over the
164 * TYPE_REQUEST_ALIVE entries which wrap TYPE_URL_REQUEST_START / 164 * TYPE_REQUEST_ALIVE entries which wrap TYPE_URL_REQUEST_START /
165 * TYPE_SOCKET_STREAM_CONNECT. 165 * TYPE_SOCKET_STREAM_CONNECT.
166 * 166 *
167 * TODO(eroman): Get rid of TYPE_REQUEST_ALIVE so this isn't necessary. 167 * TODO(eroman): Get rid of TYPE_REQUEST_ALIVE so this isn't necessary.
168 */ 168 */
(...skipping 22 matching lines...) Expand all
191 SourceEntry.prototype.getSourceId = function() { 191 SourceEntry.prototype.getSourceId = function() {
192 return this.entries_[0].source.id; 192 return this.entries_[0].source.id;
193 }; 193 };
194 194
195 SourceEntry.prototype.remove = function() { 195 SourceEntry.prototype.remove = function() {
196 this.setSelected(false); 196 this.setSelected(false);
197 this.setIsMatchedByFilter(false); 197 this.setIsMatchedByFilter(false);
198 this.row_.parentNode.removeChild(this.row_); 198 this.row_.parentNode.removeChild(this.row_);
199 }; 199 };
200 200
OLDNEW
« no previous file with comments | « chrome/browser/resources/net_internals/logviewpainter.js ('k') | net/base/host_resolver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698