content/browser/frame_host/render_frame_host_manager.cc - Issue 1715993002: OOPIF: Fix remote frame navigations from extension pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1715993002: OOPIF: Fix remote frame navigations from extension pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl.cc ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_proxy_host.cc » ('j') | content/browser/frame_host/render_frame_proxy_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index cd1684b769a1b7479a79e30536bf586b6eafeec9..3771c1ff393131201b6c14e415340e9f57927ee1 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -470,7 +470,7 @@ void RenderFrameHostManager::OnCrossSiteResponse(

rest_of_chain.pop_back();

pending_render_frame_host->frame_tree_node()->navigator()->RequestTransferURL(

- pending_render_frame_host, transfer_url, rest_of_chain, referrer,

+ pending_render_frame_host, transfer_url, nullptr, rest_of_chain, referrer,

page_transition, global_request_id, should_replace_current_entry);

// The transferring request was only needed during the RequestTransferURL