Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171593002: Rename ChromeShellWindowDelegate to ChromeAppWindowDelegate (Closed)

Created:
6 years, 10 months ago by scheib
Modified:
6 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, tfarina, kalyank, chromium-apps-reviews_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Rename ChromeShellWindowDelegate to ChromeAppWindowDelegate Follow up from ShellWindow -> AppWindow rename in http://crbug.com/343591 BUG=344084 TBR=jamescook@chromium.org chrome/browser/ui/ash/* TBR=benwells@chromium.org chrome/browser/ui/{cocoa,gtk,views}* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252090

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -437 lines) Patch
M chrome/browser/apps/app_browsertest_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/apps/chrome_app_window_delegate.h View 1 3 chunks +12 lines, -13 lines 0 comments Download
A + chrome/browser/ui/apps/chrome_app_window_delegate.cc View 7 chunks +29 lines, -30 lines 0 comments Download
D chrome/browser/ui/apps/chrome_shell_window_delegate.h View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/ui/apps/chrome_shell_window_delegate.cc View 1 chunk +0 lines, -225 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/apps/chrome_app_window_delegate_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/chrome_shell_window_delegate_cocoa.mm View 1 chunk +0 lines, -14 lines 0 comments Download
A + chrome/browser/ui/gtk/apps/chrome_app_window_delegate_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/apps/chrome_shell_window_delegate_gtk.cc View 1 chunk +0 lines, -14 lines 0 comments Download
A + chrome/browser/ui/views/apps/chrome_app_window_delegate_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/apps/chrome_app_window_delegate_views_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_shell_window_delegate_views.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_shell_window_delegate_views_win.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scheib
6 years, 10 months ago (2014-02-19 15:39:15 UTC) #1
Ken Rockot(use gerrit already)
LGTM with small nit https://codereview.chromium.org/171593002/diff/210001/chrome/browser/ui/apps/chrome_app_window_delegate.h File chrome/browser/ui/apps/chrome_app_window_delegate.h (right): https://codereview.chromium.org/171593002/diff/210001/chrome/browser/ui/apps/chrome_app_window_delegate.h#newcode32 chrome/browser/ui/apps/chrome_app_window_delegate.h:32: // TODO(jamescook): Rename to ChromeAppWindowDelegate. ...
6 years, 10 months ago (2014-02-19 15:47:28 UTC) #2
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 10 months ago (2014-02-19 15:51:55 UTC) #3
scheib
thx https://codereview.chromium.org/171593002/diff/210001/chrome/browser/ui/apps/chrome_app_window_delegate.h File chrome/browser/ui/apps/chrome_app_window_delegate.h (right): https://codereview.chromium.org/171593002/diff/210001/chrome/browser/ui/apps/chrome_app_window_delegate.h#newcode32 chrome/browser/ui/apps/chrome_app_window_delegate.h:32: // TODO(jamescook): Rename to ChromeAppWindowDelegate. http://crbug.com/344084 On 2014/02/19 ...
6 years, 10 months ago (2014-02-19 15:52:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/171593002/280001
6 years, 10 months ago (2014-02-19 15:53:21 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 21:10:00 UTC) #6
Message was sent while issue was closed. 
Change committed as 252090

Powered by Google App Engine
This is Rietveld 408576698