Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2492)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager_commands.js

Issue 17159005: Fixed links in the Files.app's gear menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/file_manager_commands.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager_commands.js b/chrome/browser/resources/file_manager/js/file_manager_commands.js
index 06297ead7ddd2c51ed9c6147fb5cc4679bd06c64..a7ad15fc22d8cb6e035a7676e796c42c91c38a7d 100644
--- a/chrome/browser/resources/file_manager/js/file_manager_commands.js
+++ b/chrome/browser/resources/file_manager/js/file_manager_commands.js
@@ -317,9 +317,9 @@ Commands.renameFileCommand = {
Commands.volumeHelpCommand = {
execute: function() {
if (fileManager.isOnDrive())
- window.open(FileManager.GOOGLE_DRIVE_HELP, 'help');
+ chrome.tabs.create({ url: FileManager.GOOGLE_DRIVE_HELP });
else
- window.open(FileManager.FILES_APP_HELP, 'help');
+ chrome.tabs.create({ url: FileManager.FILES_APP_HELP });
},
canExecute: function(event, fileManager) {
event.canExecute = true;
@@ -331,7 +331,7 @@ Commands.volumeHelpCommand = {
*/
Commands.driveBuySpaceCommand = {
execute: function() {
- window.open(FileManager.GOOGLE_DRIVE_BUY_STORAGE, 'buy-more-space');
+ chrome.tabs.create({ url: FileManager.GOOGLE_DRIVE_BUY_STORAGE });
},
canExecute: CommandUtil.canExecuteVisibleOnDriveOnly
};
@@ -361,7 +361,7 @@ Commands.driveReloadCommand = {
*/
Commands.driveGoToDriveCommand = {
execute: function() {
- window.open(FileManager.GOOGLE_DRIVE_ROOT, 'drive-root');
+ chrome.tabs.create({ url: FileManager.GOOGLE_DRIVE_ROOT });
},
canExecute: CommandUtil.canExecuteVisibleOnDriveOnly
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698