Issue 17159005: Fixed links in the Files.app's gear menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17159005: Fixed links in the Files.app's gear menu. (Closed)

Created:
7 years, 6 months ago by hirono

Modified:
7 years, 6 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed links in the Files.app's gear menu. This CL changed how to open URLs from window.open to chrome.tabs.create. BUG=248449 TEST=manually R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206920

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager_commands.js	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/17159005/1

7 years, 6 months ago (2013-06-18 04:03:20 UTC) #4

hirono

Committed patchset #1 manually as r206920 (presubmit successful).

7 years, 6 months ago (2013-06-18 08:22:56 UTC) #5

mtomasz

7 years, 6 months ago (2013-06-19 03:40:18 UTC) #6

Message was sent while issue was closed.

On 2013/06/18 08:22:56, hirono wrote:
> Committed patchset #1 manually as r206920 (presubmit successful).

Sorry, but it seem not to work when there is no active window. You may want to
use chrome.windows.create().

Expand Messages | Collapse Messages