Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 17159005: Fixed links in the Files.app's gear menu. (Closed)

Created:
7 years, 6 months ago by hirono
Modified:
7 years, 6 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fixed links in the Files.app's gear menu. This CL changed how to open URLs from window.open to chrome.tabs.create. BUG=248449 TEST=manually R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager_commands.js View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
Could you check the CL? Thank you very much!
7 years, 6 months ago (2013-06-17 23:49:55 UTC) #1
yoshiki
lgtm
7 years, 6 months ago (2013-06-18 00:48:43 UTC) #2
hirono
On 2013/06/18 00:48:43, yoshiki wrote: > lgtm Thanks!
7 years, 6 months ago (2013-06-18 01:36:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/17159005/1
7 years, 6 months ago (2013-06-18 04:03:20 UTC) #4
hirono
Committed patchset #1 manually as r206920 (presubmit successful).
7 years, 6 months ago (2013-06-18 08:22:56 UTC) #5
mtomasz
7 years, 6 months ago (2013-06-19 03:40:18 UTC) #6
Message was sent while issue was closed.
On 2013/06/18 08:22:56, hirono wrote:
> Committed patchset #1 manually as r206920 (presubmit successful).

Sorry, but it seem not to work when there is no active window. You may want to
use chrome.windows.create().

Powered by Google App Engine
This is Rietveld 408576698