Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 1715853002: Insert an empty image when we cannot decode (Closed)

Created:
4 years, 10 months ago by scroggo
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Insert an empty image when we cannot decode In SKP deserialization, if there is a 0 byte encoded image, we insert an empty image into the output SkPicture so that we can continue deserializing. Do the same when our decoder cannot decode it. This may be the result of a bug in our decoder, or in the stream serialization. But it should not mean the entire stream is invalid. BUG=skia:4691 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715853002 Committed: https://skia.googlesource.com/skia/+/950fb1ca24cca9803eb29dc6aa5472b0f506a67f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/core/SkReadBuffer.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
4 years, 10 months ago (2016-02-19 19:25:12 UTC) #3
mtklein
lgtm
4 years, 10 months ago (2016-02-19 19:30:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715853002/1
4 years, 10 months ago (2016-02-19 19:33:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 20:08:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/950fb1ca24cca9803eb29dc6aa5472b0f506a67f

Powered by Google App Engine
This is Rietveld 408576698