Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171583002: linux_aura: Default use_gnome_keyring% to on when use_aura=1. (Closed)

Created:
6 years, 10 months ago by Elliot Glaysher
Modified:
6 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

linux_aura: Default use_gnome_keyring% to on when use_aura=1. BUG=342106 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251992

Patch Set 1 #

Patch Set 2 : Link directly with gnome keyring in the unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
6 years, 10 months ago (2014-02-18 23:27:39 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 10 months ago (2014-02-18 23:50:19 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 10 months ago (2014-02-19 02:56:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/171583002/70001
6 years, 10 months ago (2014-02-19 02:58:11 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 08:12:33 UTC) #5
Message was sent while issue was closed. 
Change committed as 251992

Powered by Google App Engine
This is Rietveld 408576698