runtime/bin/directory_macos.cc - Issue 17158003: Report async errors when they happend, in directory listing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/directory_macos.cc

Issue 17158003: Report async errors when they happend, in directory listing. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/directory_macos.cc

diff --git a/runtime/bin/directory_macos.cc b/runtime/bin/directory_macos.cc

index 20803c2c71b644d38117bf610b6e3e4a98214a30..88e430ba3b3af2e14d8ff1d02b4c9ea3140923ac 100644

--- a/runtime/bin/directory_macos.cc

+++ b/runtime/bin/directory_macos.cc

@@ -49,7 +49,7 @@ bool PathBuffer::Add(const char* name) {

data[PATH_MAX] = '\0';

if (written <= PATH_MAX - length_ &&

written >= 0 &&

- static_cast<size_t>(written) == strnlen(name, PATH_MAX + 1)) {

+ static_cast<size_t>(written) == strlen(name)) {

length_ += written;

return true;

} else {

« no previous file with comments | « runtime/bin/directory.cc ('k') | sdk/lib/io/directory_impl.dart » ('j') | no next file with comments »