Report async errors when they happend, in directory listing.

runtime/bin/directory.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/directory.h"
 
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 #include "include/dart_api.h"
 #include "platform/assert.h"
@@ skipping 224 matching lines @@
       request[1]->IsString() &&
       request[2]->IsBool() &&
       request[3]->IsBool()) {
     CObjectString path(request[1]);
     CObjectBool recursive(request[2]);
     CObjectBool follow_links(request[3]);
     AsyncDirectoryListing* dir_listing =
         new AsyncDirectoryListing(path.CString(),
                                   recursive.Value(),
                                   follow_links.Value());
+    if (dir_listing->error()) {
+      // Report error now, so we capture the correct OSError.
+      CObject* err = CObject::NewOSError();
+      delete dir_listing;
+      CObjectArray* error = new CObjectArray(CObject::NewArray(3));
+      error->SetAt(0, new CObjectInt32(
+          CObject::NewInt32(AsyncDirectoryListing::kListError)));
+      error->SetAt(1, request[1]);
+      error->SetAt(2, err);
+      return error;
+    }
     // TODO(ajohnsen): Consider returning the first few results.
     return new CObjectIntptr(CObject::NewIntptr(
         reinterpret_cast<intptr_t>(dir_listing)));
   }
   return CreateIllegalArgumentError();
 }
 
 
 static CObject* DirectoryListNextRequest(const CObjectArray& request) {
   if (request.Length() == 2 &&
@@ skipping 127 matching lines @@
 bool AsyncDirectoryListing::HandleLink(char* link_name) {
   return AddFileSystemEntityToResponse(kListLink, link_name);
 }
 
 void AsyncDirectoryListing::HandleDone() {
   AddFileSystemEntityToResponse(kListDone, NULL);
 }
 
 
 bool AsyncDirectoryListing::HandleError(const char* dir_name) {
+  CObject* err = CObject::NewOSError();
   array_->SetAt(index_++, new CObjectInt32(CObject::NewInt32(kListError)));
-  CObject* err = CObject::NewOSError();
   CObjectArray* response = new CObjectArray(CObject::NewArray(3));
   response->SetAt(0, new CObjectInt32(CObject::NewInt32(kListError)));
   response->SetAt(1, new CObjectString(CObject::NewString(dir_name)));
   response->SetAt(2, err);
   array_->SetAt(index_++, response);
   return index_ < length_;
 }
 
 bool SyncDirectoryListing::HandleDirectory(char* dir_name) {
   Dart_Handle dir_name_dart = DartUtils::NewString(dir_name);
@@ skipping 70 matching lines @@
   if (listing->error()) {
     listing->HandleError("Invalid path");
     listing->HandleDone();
   } else {
     while (ListNext(listing)) {}
   }
 }
 
 }  // namespace bin
 }  // namespace dart