Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1715723002: Fix node replacer to handle comments on variable declaration lists (issue 25818) (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix node replacer to handle comments on variable declaration lists (issue 25818) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e46eaa3072dfd4a83c238f1736b1e6909060e392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-19 16:07:22 UTC) #3
scheglov
LGTM
4 years, 10 months ago (2016-02-19 16:27:53 UTC) #4
Brian Wilkerson
4 years, 10 months ago (2016-02-19 16:45:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e46eaa3072dfd4a83c238f1736b1e6909060e392 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698