Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 17157005: Reland r9682, using new SkString::appendU64() (Closed)

Created:
7 years, 6 months ago by epoger
Modified:
7 years, 6 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Reland r9682, using new SkString::appendU64() Committed: https://code.google.com/p/skia/source/detail?r=9687

Patch Set 1 #

Total comments: 1

Patch Set 2 : use_appendU64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -13 lines) Patch
M gm/gm_expectations.h View 1 chunk +21 lines, -0 lines 0 comments Download
M gm/gm_expectations.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download
M gm/gmmain.cpp View 15 chunks +53 lines, -22 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/command_line View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/json-summary.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/mismatchPath/bitmap-64bitMD5_selftest1_1209453360120438698.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/mismatchPath/bitmap-64bitMD5_selftest1_12927999507540085554.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/return_value View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/stdout View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/writePath/bitmap-64bitMD5_selftest1_1209453360120438698.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/checksum-based-filenames/output-expected/writePath/bitmap-64bitMD5_selftest1_12927999507540085554.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/tests/run.sh View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
epoger
https://codereview.chromium.org/17157005/diff/1/gm/gm_expectations.h File gm/gm_expectations.h (right): https://codereview.chromium.org/17157005/diff/1/gm/gm_expectations.h#newcode79 gm/gm_expectations.h:79: /** Patchset 1 relands r9682 in its original form ...
7 years, 6 months ago (2013-06-19 16:07:04 UTC) #1
epoger
7 years, 6 months ago (2013-06-19 18:28:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r9687 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698