chrome/renderer/spellchecker/spellcheck.cc - Issue 1715683002: chrome: Use base's ContainsValue helper function instead of std::find

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/spellchecker/spellcheck.cc

Issue 1715683002: chrome: Use base's ContainsValue helper function instead of std::find (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing non ContainsValue changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/predictors/autocomplete_action_predictor.cc ('K') | « chrome/browser/ui/webui/chromeos/login/l10n_util.cc ('k') | chrome/test/chromedriver/chrome/device_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/spellchecker/spellcheck.cc

diff --git a/chrome/renderer/spellchecker/spellcheck.cc b/chrome/renderer/spellchecker/spellcheck.cc

index cb8040e63369c9f070b0a0f171dd30621f8e93ec..f181cf2db308d6d4b0b449db6552e1d1ed1f4247 100644

--- a/chrome/renderer/spellchecker/spellcheck.cc

+++ b/chrome/renderer/spellchecker/spellcheck.cc

@@ -15,6 +15,7 @@

#include "base/logging.h"

#include "base/macros.h"

#include "base/single_thread_task_runner.h"

+#include "base/stl_util.h"

#include "base/thread_task_runner_handle.h"

#include "build/build_config.h"

#include "chrome/common/channel_info.h"

@@ -194,8 +195,7 @@ void SpellCheck::FillSuggestions(

const base::string16& suggestion = suggestions_list[language][index];

// Only add the suggestion if it's unique.

- if (std::find(optional_suggestions->begin(), optional_suggestions->end(),

- suggestion) == optional_suggestions->end()) {

+ if (!ContainsValue(*optional_suggestions, suggestion)) {

optional_suggestions->push_back(suggestion);

}

if (optional_suggestions->size() >=